Ben, I pushed this after I removed the offending assert and changed to use normal hton macros.
I had forgot the line in there, was testing for alignment just for my own understanding. flow_compose() would be little simpler if we had the 32-bit aligned header definitions available. I felt hesitant about using the Linux definitions, as they might not be portable to other systems. Thanks, Jarno On Dec 6, 2013, at 10:04 AM, Ben Pfaff <[email protected]> wrote: > On Fri, Dec 06, 2013 at 09:46:29AM -0800, Ben Pfaff wrote: >> On Thu, Dec 05, 2013 at 04:27:25PM -0800, Jarno Rajahalme wrote: >>> Add the missing code for generating IPv6 packets for testing purposes. >>> >>> Also make flow_compose() set the l4 and l7 pointers more consistently >>> with flow_extract(). >>> >>> Signed-off-by: Jarno Rajahalme <[email protected]> >> >> Would you please use uintptr_t instead of uint64_t here? Also, I am not >> sure what the comment means. >>> + ovs_assert((uint64_t)b->l3 % 4 == 0); /* Testing... */ > > As an aside, Clang warns about this: > > ../lib/flow.c: In function 'flow_compose': > ../lib/flow.c:1154:5: error: cast from pointer to integer of different > size [-Werror=pointer-to-int-cast] _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
