On Tue, Dec 10, 2013 at 11:36 AM, David Miller <[email protected]> wrote: > From: Jesse Gross <[email protected]> > Date: Tue, 10 Dec 2013 11:28:08 -0800 > >> I think this is definitely a good optimization to do given that so >> much of the work that OVS does is hashing. However, isn't there a >> library where there would be a more appropriate place to put this? > > I also honestly don't see why we want to special case OVS at all > here. This faster hashing would be useful for socket demux and > other locations in the kernel. >
Also, we already do a lot of work to compute flow hashes for packets in both TX and RX. Can these be leveraged? For instance, if OVS is computing a 5-tuple hash on an RX packet it's probably redundant to skb->rxhash. > When I see changes like this my only reaction is "sad face". > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
