On Tue, Nov 05, 2013 at 05:35:03PM +0900, Simon Horman wrote:
> ovs-ofctl needs to mask the allowed protocols with the usable protocols
> after calling parse_ofp_str() so that only usable protocols will be
> negotiated.
> 
> This problem became apparent to me after 8621547cc94ad910
> ("lib/ofp-actions: Enforce action consistency.") as it allows
> parse_ofp_str() to reduce the maximum usable protocol. As the highest
> mutually supported protocol is negotiated this can easily lead to
> negotiation of a protocol that is not allowed.
> 
> Also add a for this case.  And another test that that the allowed protocols
> is honoured even when usable protocols doesn't restrict it - which works
> even without the code-change in this patch.
> 
> Cc: Jarno Rajahalme <jrajaha...@nicira.com>
> Signed-off-by: Simon Horman <ho...@verge.net.au>

I see that this never got reviewed.  I must have missed it.  If it is
still relevant, will you please rebase and repost?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to