On Sun, Jan 05, 2014 at 03:13:53PM +0900, Simon Horman wrote: > On Sun, Dec 29, 2013 at 08:02:34PM -0800, Ben Pfaff wrote: > > On Sat, Dec 28, 2013 at 11:50:44PM -0800, Ben Pfaff wrote: > > > I've been a little frustrated with the current approach to MPLS, because > > > it > > > seems quite difficult to understand. One particularly difficult bit for > > > me is the variables used during translation, e.g. mpls_depth_delta and > > > pre_push_mpls_lse. And what we end up with is support for a single MPLS > > > label, which I don't think is going to make any real-world users happy. > > > > > > This commit attempts to implement something easier to understand and more > > > powerful by just keeping track of all the labels in struct flow. > > > > > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > > Co-authored-by: Simon Horman <ho...@verge.net.au> > > > Signed-off-by: Simon Horman <ho...@verge.net.au> > > > > I'm looking for a review of this patch. Simon, are you happy with it? > > Anyone else have comments? > > Hi Ben, > > I apologise for not answering earlier, I have been on vacation for > the past week. I plan to review it tomorrow but in general if it > is v1 of your patch plus the patches I posted which you said you have > folded in, then I am comfortable with it.
Apologies once again for the delayed response. I have reviewed this and not withstanding Jesse's comments, which I will dedicate some thought to, I am happy with this patch as I believe it works as well as v1 + the incremental patches which I posted. Acked-by: Simon Horman <ho...@verge.net.au> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
