> +         *      installed in the kernel already. */
> +        if (may_put
> +            && !miss->put
> +            && (!miss->xout.slow
> +                || upcall->dpif_upcall.type == DPIF_UC_MISS)) {

My only question here is why not just say, we only install flows with
DPIF_UC_MISS, instead of making that check only for xout.slow?

Ethan




>
> +            miss->put = true;
> +
>              atomic_read(&enable_megaflows, &megaflow);
>              ofpbuf_use_stack(&mask, &miss->mask_buf, sizeof miss->mask_buf);
>              if (megaflow) {
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to