On Fri, Jan 24, 2014 at 10:24:51AM -0800, Jarno Rajahalme wrote:
> 
> On Jan 24, 2014, at 9:23 AM, Ben Pfaff <[email protected]> wrote:
> 
> > On Fri, Jan 24, 2014 at 09:13:58AM -0800, Jarno Rajahalme wrote:
> >> 
> >> On Jan 22, 2014, at 4:11 PM, Ben Pfaff <[email protected]> wrote:
> >> 
> >>> Signed-off-by: Ben Pfaff <[email protected]>
> >>> +#include <urcu-qsbr.h>
> >> 
> >> This file doesn?t exist. Should I install something to get this?
> > 
> > You need liburcu.  On Debian: "apt-get install liburcu-dev".
> 
> I see roughly a 10% increase in TCP_CRR flow set-up rate with this
> patch series, so definitely the right way to go. 

That's good news; it's what I wanted to hear.  It means that it is worth
taking the time to polish up the series and get it committed.

> I still see ofproto_rule_ref/unref having a notable cost due to the
> atomic count:

I only switched one little piece of the ofproto code to use RCU, just to
see if it helped.  Now that I hear that it did, there's plenty of
opportunity for further improvement.

I'll work on this series then.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to