On Fri, Feb 14, 2014 at 2:20 PM, Gurucharan Shetty <[email protected]> wrote: > Some functions are unused and one of it can be declared as static.
I decided to abandon this particular patch as there may be other users that use libopenvswitch. Thanks, Guru > > Signed-off-by: Gurucharan Shetty <[email protected]> > --- > lib/process.c | 28 ++-------------------------- > lib/process.h | 4 ---- > 2 files changed, 2 insertions(+), 30 deletions(-) > > diff --git a/lib/process.c b/lib/process.c > index 5dd34b3..82a7693 100644 > --- a/lib/process.c > +++ b/lib/process.c > @@ -55,6 +55,7 @@ static int fds[2]; > /* All processes. */ > static struct list all_processes = LIST_INITIALIZER(&all_processes); > > +static char *process_search_path(const char *name); > static void sigchld_handler(int signr OVS_UNUSED); > > /* Initializes the process subsystem (if it is not already initialized). > Calls > @@ -225,31 +226,6 @@ process_destroy(struct process *p) > } > } > > -/* Sends signal 'signr' to process 'p'. Returns 0 if successful, otherwise a > - * positive errno value. */ > -int > -process_kill(const struct process *p, int signr) > -{ > - return (p->exited ? ESRCH > - : !kill(p->pid, signr) ? 0 > - : errno); > -} > - > -/* Returns the pid of process 'p'. */ > -pid_t > -process_pid(const struct process *p) > -{ > - return p->pid; > -} > - > -/* Returns the name of process 'p' (the name passed to process_start() with > any > - * leading directories stripped). */ > -const char * > -process_name(const struct process *p) > -{ > - return p->name; > -} > - > /* Returns true if process 'p' has exited, false otherwise. */ > bool > process_exited(struct process *p) > @@ -337,7 +313,7 @@ process_wait(struct process *p) > } > } > > -char * > +static char * > process_search_path(const char *name) > { > char *save_ptr = NULL; > diff --git a/lib/process.h b/lib/process.h > index 3feac7e..a04318f 100644 > --- a/lib/process.h > +++ b/lib/process.h > @@ -31,9 +31,6 @@ struct process; > void process_init(void); > int process_start(char **argv, struct process **); > void process_destroy(struct process *); > -int process_kill(const struct process *, int signr); > -pid_t process_pid(const struct process *); > -const char *process_name(const struct process *); > bool process_exited(struct process *); > int process_status(const struct process *); > void process_run(void); > @@ -42,6 +39,5 @@ void process_wait(struct process *); > /* These functions are thread-safe. */ > char *process_status_msg(int); > char *process_escape_args(char **argv); > -char *process_search_path(const char *); > > #endif /* process.h */ > -- > 1.7.9.5 > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
