On Tue, Mar 04, 2014 at 11:47:43AM +0100, Luigi Rizzo wrote:
> On Fri, Jan 24, 2014 at 1:55 AM, Ben Pfaff <[email protected]> wrote:
> >
> > - Instead of (LINUX_DATAPATH && !HAVE_IF_DL), write just
> > __linux__. In the cases I looked at, the interface didn't
> > seem too likely to be of interest outside Linux.
> >
>
> For this one there are only two things to keep in mind:
> 1. lib/automake.mk has no access to __linux__
> so we should define some other variable in the autoconf files.
> Any suggestion ?
Let's use autoconf and automake to define a LINUX automake conditional
if __linux__ is defined.
> 2. our lib/automake.mk which compiles NETLINK_DATAPATH
> on FreeBSD has a block as follows (indentation for readability):
>
> if NETLINK_DATAPATH
> lib_libopenvswitch_la_SOURCES += \
> lib/dpif-linux.c \
> ... # other common files
> if HAVE_IF_DL
> else
> lib_libopenvswitch_la_SOURCES += \
> lib/netdev-linux.c \
> ... # other linux-specific files
> endif
> endif
>
> our lib/netdev.c has a similar block in netdev_initialize()
>
> So moving these inner blocks outside would probably make
> the structure less readable.
I'd suggest
if NETLINK_DATAPATH
...
if LINUX
...
fi
fi
unless I misunderstand the intent.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
