On Thu, Mar 6, 2014 at 1:57 PM, Kyle Mestery <mest...@noironetworks.com> wrote: > On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar <pshe...@nicira.com> wrote: >> >> On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery >> <mest...@noironetworks.com> wrote: >> > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar <pshe...@nicira.com> >> > wrote: >> >> >> >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery >> >> <mest...@noironetworks.com> >> >> wrote: >> >> > I see this patch [1] in patchwork now from Pravin via James Page. >> >> > I pulled this down and started to look at what it would take to get >> >> > this >> >> > also working with 3.13. It looks like the netlink interfaces changed >> >> > a >> >> > bit here. Is anyone working on this at the moment? If not, I'd like >> >> > to >> >> > take this on. Secondly, how are things like this handled in the >> >> > datapath >> >> > now. I'm hesitant to put a bunch of #ifdefs in the code there. >> >> > Guidance >> >> > appreciated. >> >> > >> >> I do not think anyone is working on 3.13 support. >> >> I have not looked at netlink changes but lets try to avoid #ifdef as >> >> much possible. We can add compat code to compat directory to handle >> >> any API change. >> >> >> > OK, agreed. >> > >> >> >> >> > Thanks, >> >> > Kyle >> >> > >> >> > [1] http://patchwork.openvswitch.org/patch/2972/ >> >> > >> >> >> >> If you or someone else review it, I can apply this patch. >> >> >> > I just updated patchwork to assign this one to myself, reviewing it now. >> > Is the workflow such that if I click "approve" in patchwork it will >> > automatically >> > merge the patch? Do I still need to send an email to the list with the >> > standard "Reviewed-by" or "Acked-by"? >> > >> yes, review is still done on mailing list. patchwork is to mostly used >> to track remaining reviews. >> > So, I don't have the original email to reply to here, but I've reviewed this > patch in patchwork here [1], and it looks fine to me. > > Reviewed-by: Kyle Mestery <mest...@noironetworks.com> > Thanks. I pushed it to master.
> Pravin, once this goes in, I'll look into 3.13 support next if that's ok > with > you. > > Thanks, > Kyle > > [1] http://patchwork.openvswitch.org/patch/2972/ > >> >> >> >> >> >> >> >> > _______________________________________________ >> >> > dev mailing list >> >> > dev@openvswitch.org >> >> > http://openvswitch.org/mailman/listinfo/dev >> >> > >> > >> > > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
