> - fold in Ben's clarification.
> > - refine the comments.
> > - invoke dpif_handlers_set() in udpif_set_threads(). this is a bug.
> > the previous code will cause the handlers polling from closed
> > fd.
>
> I'm still trying to figure out whether I properly understand the new
> API. Here's a suggested replacement for the first paragraph of the
> comment on 'port_get_pid'. Is it correct?
>
> /* Returns the Netlink PID value to supply in OVS_ACTION_ATTR_USERSPACE
> * actions as the OVS_USERSPACE_ATTR_PID attribute's value, for use in
> * flows whose packets arrived on port 'port_no'. In the case where
> the
> * provider allocates multiple Netlink PIDs to a single port, it may
> use
> * 'hash' to spread load among them. The caller need not use a
> particular
> * hash function, because it is not generally necessary to avoid
> reordering
> * between packets received via flow misses (which are spread among
> PIDs by
> * the datapath internally) and those received via userspace actions
> (which
> * are spread via the return value of this function). A 5-tuple hash
> is
> * suitable.
>
>
Thanks for pointing out the reordering issue, the suggested comment makes
sense.
I'm not sure if it is good grammar, but can I add one more 'between' like
below?
/* Returns the Netlink PID value to supply in OVS_ACTION_ATTR_USERSPACE
* actions as the OVS_USERSPACE_ATTR_PID attribute's value, for use in
* flows whose packets arrived on port 'port_no'. In the case where the
* provider allocates multiple Netlink PIDs to a single port, it may use
* 'hash' to spread load among them. The caller need not use a
particular
* hash function, because it is not generally necessary to avoid
reordering
* between packets received via flow misses (which are spread among
PIDs by
* the datapath internally) and *between *those received via userspace
actions (which
* are spread via the return value of this function), (e.g. sampling
actions).
* A 5-tuple hash is suitable.
Hope to hear more about the API,
Alex Wang,
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
