On Mar 18, 2014, at 8:38 PM, Pravin Shelar <[email protected]> wrote:
> On Tue, Mar 18, 2014 at 4:04 PM, Jarno Rajahalme <[email protected]>
> wrote:
>>
>> On Mar 18, 2014, at 1:53 PM, Pravin <[email protected]> wrote:
>>
>>> DPDK netdev need to access ofpbuf while sending buffer. Following
>>> patch changes netdev_send accordingly.
>>
>> Would it still be possible to not transfer the responsibility of freeing the
>> buffer? This relates to the comments I sent for patch 1.
>>
> I need to do that for better performance.
The code before the patches minimized copying of the data, by not requiring a
fresh copy to begin with, and allowing the execution code to steal the data,
when it was known that it is no longer needed (e.g. the last output or
userspace action). I’d like you to elaborate a bit on how the new design is
better. For example, it seems to me that requiring the action execution code to
free the ofpbuf itself should not be necessary, and would allow for different
code paths to use different memory strategies, i.e., the “execute” path need
not allocate a new ofpbuf (so it need not be deleted), while the “port input”
path could allocate and free ofpbufs before and after invoking the action
execution code, respectively.
Jarno
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
