Pushed with the modifications proposed, thanks for the review! Jarno
On Mar 24, 2014, at 1:57 PM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Mar 24, 2014 at 10:59:04AM -0700, Jarno Rajahalme wrote: >> Inline the most trivial ofpbuf functions to allow for better optimization. >> Also inline the most often used ofpbuf_pull() and ofpbuf_try_pull(), which >> should help streamline packet parsing. >> >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > For inlining, I usually lean toward leaving the prototypes in their > places (you do have to add "static inline" to each one) and then > putting the implementation near the end of the header file. That way, > it's easy to get an idea of the API at a glance without having the > code cluttered with the implementation details. > > Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
