On Mon, Mar 31, 2014 at 01:19:39PM -0700, Ben Pfaff wrote: > On Tue, Mar 25, 2014 at 02:50:17PM -0300, Flavio Leitner wrote: > > It should be an administrator task to bring up devices as they > > are configured properly. > > > > Currently, Fedora is deleting the bridges when the interface is > > brought down. Therefore, there is no bridge on the next boot and > > the initscripts can apply the networking configuration properly > > for a new bridge. > > > > However, if the system didn't execute ifdown for some reason, the > > bridge is left in the ovsdb and since internal ports are brought > > up by default, there is no way for initscripts to known if the > > adminitrator has configured it or not already. > > > > This patch partially reverts the commit > > bef071a5fdf8e2dd87677b04b3cf7a8f5094edcb > > > > Signed-off-by: Flavio Leitner <f...@redhat.com> > > I think you're right, that this is correct, but let's put the NEWS > item at the top and give a little more explanation, something like > this: > > - Internal ports are no longer brought up by default, because it should be > an administrator task to bring up devices as they are configured > properly. > > This is almost certain to break some people's setups, but I guess it's > better than what we do now. > > Please give a title when referring to a commit in a log message, e.g.: > > This patch partially reverts the commit > bef071a5fdf8e2dd87677b04b3cf7a8f5094edcb (bridge: Always "up" internal > devices.). > > Finally, I would have just fixed all of the above and pushed it, > except that it also breaks half a dozen tests in the testsuite. > Please fix those and submit a v3.
Sure, I will fix the patch with your suggestions and post a v3. Thank for reviewing it. fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
