On Thu, Mar 27, 2014 at 09:44:18AM -0700, Pravin wrote: > This patch does not change any functionality. > > Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
I don't like seeing this as a global variable. Can it be per-datapath (probably set using a new provider callback function)? Did you look for races as ofprotos and datapaths are created and destroyed? Before this series, an ofproto upcall thread could only process a packet when it was in a state where it expected it, and it is not obvious at a glance that this is still true when a callback can be issued asynchronously at any moment. In the short term, while we're developing the DPDK code, I think that having an alternate interface like this to packet misses is OK. But in the long term, I don't really like having two different interfaces to the same functionality, that is, two ways to get misses and other packets from a dpif to the code that consumes it. Do you think that it will be possible to use callbacks exclusively, instead of sometimes callbacks and sometimes queues, and then delete the bits of the interface that support queuing? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
