On Tue, Apr 08, 2014 at 10:20:54AM +0900, YAMAMOTO Takashi wrote: > > On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > >> > Uniformly wait for calls to ovs-ofctl exit using > >> > OVS_APP_EXIT_AND_WAIT() in the test-suite. > >> > >> are they all necessary to avoid some races? > >> > >> in commit 0c473314, i intended to make it wait only when necessary. > >> ie. only tests which have multiple "ovs-ofctl --pidfile". > > > > Ok, understood. > > > > This patch did not aim to address any problems that I had observed. > > Merely to make things uniform. So I'm happy for it to be dropped > > partially or entirely. But I am curious to know how you determine if > > waiting is necessary. > > i observed test failures due to this. ovs-ofctl complained there's > a pid file already. > i have no mechanical way to find out where it's necessary. > just reading the tests. > (so it's quite possible i missed some places.)
Thanks, I understand. If I notice any more problems during testing then I'll create patches accordingly. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
