Thanks for the quick review. Fixed and pushed.
On Wed, Apr 16, 2014 at 8:47 AM, Jarno Rajahalme <[email protected]> wrote: > For the series, assuming you fix the Signed-off-by line: > > Acked-by: Jarno Rajahalme <[email protected]> > > On Apr 16, 2014, at 8:13 AM, Andy Zhou <[email protected]> wrote: > >> From: Andy Zhou <[email protected]> >> >> When recirculation is used to implement bond, the bond entry stats are >> collected from the hidden post recirculation rules. This bug causes >> double counting of stats to some strenuous bond entries. >> >> Signed-off-by: Andy Zhou <[email protected]> >> --- >> ofproto/ofproto-dpif-xlate.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c >> index 91ce7b7..cc4be6d 100644 >> --- a/ofproto/ofproto-dpif-xlate.c >> +++ b/ofproto/ofproto-dpif-xlate.c >> @@ -1169,7 +1169,7 @@ output_normal(struct xlate_ctx *ctx, const struct >> xbundle *out_xbundle, >> return; >> } >> >> - if (ctx->xin->resubmit_stats) { >> + if (ctx->xin->resubmit_stats && !ctx->xout->use_recirc) { >> bond_account(out_xbundle->bond, &ctx->xin->flow, vid, >> ctx->xin->resubmit_stats->n_bytes); >> } >> -- >> 1.9.1 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
