On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote:
> We have some common code between daemon-unix.c and
> daemon-windows.c. Move them to daemon.c
>
> Signed-off-by: Gurucharan Shetty <[email protected]>
"sparse" reports:
../lib/daemon-unix.c:42:6: warning: symbol 'detach' was not declared.
Should it be static?
../lib/daemon-unix.c:46:6: warning: symbol 'pidfile' was not declared.
Should it be static?
which is pointing out that it's unusual to have global symbols defined
without a prior "extern" declaration for the same global symbol
(usually in a header).
The "normal" way to do that is to add an extern declaration in a
header, in this case perhaps in a daemon-private.h or similar that
would only be included by daemon-{unix,windows].c.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
