On 25 April 2014 11:55, Alex Wang <[email protected]> wrote: > > +/* Current status database transaction, NULL if there is no ongoing > + * transaction. */ > +static struct ovsdb_idl_txn *status_txn; > + > +/* When the status update commit returns "TXN_INCOMPLETE", should > register a > + * timeout in "STATUS_CHECK_AGAIN_MSEC" to check again. */ > +#define STATUS_CHECK_AGAIN_MSEC 100 > + >
This could be shifted to the top of the file, next to connectivity_seqno. Not sure if you want to add a comment like the previous "instant stats" description above it too. I think it's useful to have the context that these are treated separately because we want to keep them as up-to-date as possible (with the performance tradeoff that this can't be done at large scale). Otherwise, looks good. Acked-by: Joe Stringer <[email protected]>
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
