On Thu, May 22, 2014 at 05:37:40PM -0700, Jarno Rajahalme wrote: > lib/ovs-rcu.h had some of the comments duplicated. > > Add ovsrcu_init() that can be used like ovsrcu_set() when the RCU > protected pointer is not yet visible any readers. > > Use OVS_CONSTRUCTOR to initialize the ovs-rcu module. > > Signed-off-by: Jarno Rajahalme <[email protected]>
I get nervous to start to see modules using OVS_CONSTRUCTOR to do fairly complex work. Because there is no dependency system for constructors, the order in which they are invoked is unpredictable and can vary from one compiler or system to another. If we are not perfectly careful to make sure that there are no actual dependencies among them, then that can lead to surprising crashes at startup time. I'm happy with the comment update. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
