On May 23, 2014, at 1:35 PM, Pravin Shelar <[email protected]> wrote:
>
>>
>> +/* Sends 'c' 'buffers' on 'netdev'. If 'netdev' supports batching, uses
>> + * send_batch(), otherwise iterates through 'buffers' and uses send().
>> + * Returns 0 if successful, otherwise a positive errno value.
>> + *
>> + * To retain ownership of 'buffer' caller can set may_steal to false.
>> + *
>> + * If any error occurs during the transmission of one buffer, the function
>> + * stops and return the error. */
>> +int
>> +netdev_send_batch(struct netdev *netdev, struct ofpbuf **buffers, int c,
>> + bool may_steal)
>> +{
>> + int error;
>> +
>> + error = (netdev->netdev_class->send_batch
>> + ? netdev->netdev_class->send_batch(netdev, buffers, c,
>> may_steal)
>> + : EOPNOTSUPP);
>> +
>
> Can you just add extra parameter to send call. Lets not add extra
> checks in fast path.
>
I did this to avoid changing too much code, but I see your point. I’ll add an
extra parameter to the send call.
Thanks,
Daniele
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
