On Mon, May 19, 2014 at 12:52:26PM -0700, Gurucharan Shetty wrote:
> So far, we log the kernel assigned port number when the port number is
> not specified. On Windows, this happens multiple times because "unix"
> sockets are implemented internally via TCP ports. This means that many tests,
> specially the ovs-ofctl monitor tests, need to filter out the
> additional messages. Doing that is not a big deal, but I think it will
> keep manifesting in future tests added by Linux developers.
>
> With this commit, we simply don't print the kernel assigned TCP ports
> on windows when done for "unix" sockets.
>
> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
new_pstream() looks like it has two callers with similar code:
fd = inet_open_passive(SOCK_STREAM, suffix, -1, &ss, dscp, true);
if (fd < 0) {
return -fd;
}
return new_pstream(fd, &ss, pstreamp);
and
fd = inet_open_passive(SOCK_STREAM, suffix_new, -1, &ss, dscp, false);
if (fd < 0) {
return -fd;
}
error = new_pstream(fd, &ss, pstreamp);
if (error) {
goto exit;
}
Can we move the inet_open_passive() call into new_pstream() and add a
kernel_print_port parameter to new_pstream()?
Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
