On Wed, May 28, 2014 at 05:00:48PM -0700, Andy Zhou wrote:
> In case DP_HASH and RECIRC actions need to be executed in slow path,
> current implementation simply don't handle them -- vswitchd simply
> crashes. This patch fixes them by supply an implementation for them.
>
> RECIRC will be handled by the datapath, same as the output action.
>
> DP_HASH, on the other hand, is handled in the user space. Although the
> resulting hash values may not match those computed by the datapath, it
> is less expensive; current use case (bonding) does not require a strict
> match to work properly.
>
> Reported-by: YAMAMOTO Takashi <[email protected]>
> Signed-off-by: Andy Zhou <[email protected]>
I would adjust the comment in odp_execute_actions__() to match the
changelog better, maybe:
/* Calculate a hash value directly. This might not match the
* value computed by the datapath, but it is much less expensive,
* and the current use case (bonding) does not require a strict
* match to work properly. */
Should we ovs_assert() that md->dp_hash is OVS_HASH_ALG_L4?
Presumably we won't ever create an ODP action that uses a hash
algorithm we don't implement, and if we do we ought to find out about
it.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
