Sorry, I must have pushed the wrong version. I'll send a patch.
On 3 June 2014 12:19, Jarno Rajahalme <jrajaha...@nicira.com> wrote: > > On Jun 2, 2014, at 4:55 PM, Joe Stringer <joestrin...@nicira.com> wrote: > > On 3 June 2014 08:41, Ethan Jackson <et...@nicira.com> wrote: > >> The comment over the trylock exceeds the line limit. >> > > I'll fix that up. > > >> I'm not sure if this is the right patch to fix it or not, but I don't >> like how we're overloading the meaning of the 'mark'. I think the >> code would be a lot clearer if we had both a "already_dumped" flag and >> a "delete" flag on every ukey. What do you think? >> > > I was planning to replace the mark by making use of the udpif->dump_seq, > as per the series here (Will rebase that series soon): > http://openvswitch.org/pipermail/dev/2014-May/040292.html > > >> Acked-by: Ethan Jackson <et...@nicira.com> > > > Thanks, pushed to master. > > > I’m now getting this: > > ofproto/ofproto-dpif-upcall.c:1371:36: error: use of undeclared identifier > 'key'; did you mean 'ukey'? > ukey = ukey_create(key, key_len, used); > ^~~ > ukey > ofproto/ofproto-dpif-upcall.c:1366:31: note: 'ukey' declared here > struct udpif_key *ukey = ukey_lookup(udpif, f->key, f->key_len, > ^ > ofproto/ofproto-dpif-upcall.c:1371:41: error: use of undeclared identifier > 'key_len' > ukey = ukey_create(key, key_len, used); > ^ > 2 errors generated. > > Should those be ‘f->key’ and ‘f->key_len’ instead? > > Jarno > >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
