On 06/05/14 at 10:02pm, Ben Pfaff wrote: > +/* By default, criteria initialized by rule_criteria_init() will match flows > + * that are read-only, on the assumption that the collected flows won't be > + * modified. This function to match only flows that are be modifiable. ^^^^^^^^^^^^^^^^
> + * > + * Specify 'override_readonly' as false in ordinary circumstances, true if > the > + * caller has special privileges that allow it to modify even "read-only" > + * flows. */ > +static void > +rule_criteria_require_rw(struct rule_criteria *criteria, > + bool override_readonly) > +{ > + criteria->include_readonly = override_readonly; I think this needs to be inverted as you pass True if only want RW flows. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev