On Fri, Jun 6, 2014 at 3:46 AM, Thomas Graf <[email protected]> wrote: > On 06/04/14 at 01:53pm, Andy Zhou wrote: >> Signed-off-by: Andy Zhou <[email protected]> > > I would personally value a commit message here since this looks like > more than just a simplification ;-)
The algorithm is the same. Some code movement and variable usage changes make the diff look more complicated. To improve the readability, I will make the following changes in the next version: o Add a comment along the lines of what Pravin described above. That's the main benefits of the simplification. o Split the change into two parts, the first is a stand alone simplification, without the mask array changes and the 2nd part for additional changes with the mask array changes. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
