>
> "connected"
Thanks, will fix.
>
>> + CONN_STATE_UNKNOWN, /* No relavent information. */
>> +};
>> +
>> struct dummy_packet_pconn {
>> struct pstream *pstream;
>> struct dummy_packet_stream *streams;
>> @@ -561,6 +568,24 @@ dummy_packet_conn_send(struct dummy_packet_conn *conn,
>> }
>> }
>>
>> +static enum dummy_netdev_conn_state
>> +dummy_netdev_get_conn_state(struct dummy_packet_conn *conn)
>> +{
>> + enum dummy_netdev_conn_state state;
>> +
>> + if (conn->type == ACTIVE) {
>
> This logic seems inverted from the patch description.
You are right. the patch description is right. This should be PASSIVE
>
>> + if (netdev && is_dummy_class(netdev->netdev_class)) {
>> + struct netdev_dummy *dummy_dev = netdev_dummy_cast(netdev);
>> +
>> + ovs_mutex_lock(&dummy_dev->mutex);
>
> What needs locking here? Could the locking be moved closer into the new
> function?
The conn member is declared with OVS_GUARDED in netdev_dummy. This is
to make sure
the mutex is held before accessing conn. Am I still missing something here?
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
