On Fri, May 30, 2014 at 12:06:17PM -0700, Gurucharan Shetty wrote: > Skip some of the tests that uses '--monitor' as an option as > it is not implemented on Windows. > > When a 'kill pid' is done on windows (through 'taskkill //F'), > pidfiles are not deleted (because it is force kill), so use > 'ovs-appctl exit' instead. > > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
I see that the change log explains this but I would also appreciate a comment in the .at file: > -kill `cat pid` > +if test "$IS_WIN32" = "yes"; then > + ovs-appctl -t `pwd`/unixctl exit > +else > + kill `cat pid` > +fi > OVS_WAIT_WHILE([kill -0 `cat saved-pid`]) > AT_CHECK([test ! -e pid]) > AT_CLEANUP Acked-by: Ben Pfaff <b...@nicira.com> Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
