On Wed, Jun 11, 2014 at 01:34:41PM +0900, Simon Horman wrote:
> Add helpers for allowing requests and use them in handle_openflow__().
>
> This is a in preparation for supporting multipart requests
> on a per message type basis.
>
> Signed-off-by: Simon Horman <[email protected]>
As is, ofpmsg_is_mp_request() could more concisely be implemented as
return oh->version >= OFP13_VERSION && ofpmsg_is_mp_request(oh);
ofpmsg_is_mp_request() is documented as:
> +/* Return if it's a multpart request message
> + * with more parts to follow */
which implies to me that it should check for the "more" bit (with
ofpmp_more()), but it doesn't do that.
Maybe this is a bug in the documentation, because the one caller
checks for ofpmp_more() itself:
> + if (ofpmsg_is_mp_request(oh) && ofpmp_more(oh)
> + && !ofpmsg_may_buffer_mp_request(type)) {
> + /* Report overflow for requests which consist of multiple message
> + * for which multiple message handling is not available. */
> return OFPERR_OFPBRC_MULTIPART_BUFFER_OVERFLOW;
> }
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
