Ben,

Thanks for the reviews!

I have addressed the (minor) comments on the series, will push once the vector 
v2 is ack’ed. I’ll keep this last patch as the first in the classifier RCU 
series.

  Jarno

On Jun 13, 2014, at 10:37 AM, Ben Pfaff <b...@nicira.com> wrote:

> On Mon, Jun 09, 2014 at 11:53:55AM -0700, Jarno Rajahalme wrote:
>> Use cmap instead of hmap & hindex in classifier.  Performance impact
>> with current locking strategy is not yet tested.  Later patches will
>> introduce RCU into the classifer.
> 
> into the "classifier".
> 
>> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
> 
> As long as this passes the tests (I assume you ran them) it seems OK
> to me.  The tricky review will be when we start actually making the
> classifier RCU.  (I don't know if it makes sense to push this patch
> before then.  It might be better as the first patch of a series that
> makes the classifier RCU.  But I'll leave that decision to you.)
> 
> Acked-by: Ben Pfaff <b...@nicira.com>

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to