On Tue, Jul 15, 2014 at 1:23 AM, Wenyu Zhang <wen...@vmware.com> wrote: > Hi Pravin, Thanks you for reviewing it. > > About the output tunnel info sent to userland, all the tunnel parameters in > ovs_key_ipv4_tunnel > have been sent to userland, except two parameters in geneve_opt, which is > only for GENEVE. > Do you mean that we should send the GENEVE parameters ? > Yes, that keeps kernel code simple.
> I think that it's OK to send these infos in the userspace upcall, and > userland will discard > them, due to there seems no usage about this GENEVE option in IPFIX now. > > Bests, > Wenyu > -----Original Message----- > From: Pravin Shelar [mailto:pshe...@nicira.com] > Sent: Tuesday, July 15, 2014 5:48 AM > To: Wenyu Zhang > Cc: Romain Lenglet; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] Extend OVS IPFIX exporter to export tunnel > headers > > On Sun, Jun 29, 2014 at 8:41 PM, Wenyu Zhang <wen...@vmware.com> wrote: >> Extend IPFIX exporter to export tunnel headers when both input and output >> of the port. >> Add three other_config options in IPFIX table: enable-input-sampling, >> enable-output-sampling and enable-tunnel-sampling, to control whether >> sampling tunnel info, on which direction (input or output). >> Insert sampling action before output action and the output tunnel port >> is sent to datapath in the sampling action. >> Make datapath collect output tunnel info and send it back to userpace >> in upcall message with a new additional optional attribute. >> Add a tunnel ports map to make the tunnel port lookup faster in sampling >> upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template >> sets with enterprise elements for the tunnel info, save the tunnel info >> in IPFIX cache entries, and send IPFIX DATA with tunnel info. >> Add flowDirection element in IPFIX templates. >> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
