On Wed, Jul 16, 2014 at 09:56:20AM -0700, Ben Pfaff wrote: > On Wed, Jul 16, 2014 at 10:39:17AM -0300, Flavio Leitner wrote: > > The main_loop refactoring is a nice thing even without the series, I find > > the code easier to understand. > > That's reasonable, so I applied that patch.
Thanks! > > I don't think there is a need to pre-open files in /dev since they usually > > are available inside of the chroot, right? I did a quick test with mock > > and this is what I found in there: > > > > <mock-chroot>[root@t520 /]# ls /dev > > console full ptmx random stderr stdout urandom > > fd null pts shm stdin tty zero > > > > It's been a while since I worked with chroots though. > > There's more than one way to chroot. Maybe Eric is thinking of a > model where one chroots to an empty directory, after opening all the > files that one needs. But I don't think he really explained the > model. That's true and it looks like ovsdb-server doesn't need to re-open it. But that apparently won't work for vswitchd without breaking tap devices support. I am by no means against the empty chroot idea. fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
