I’ve decided to make more changes to netdev-dpdk. I’m posting another patch with commit message "netdev-dpdk: Refactor dpdk_class_init()”
On Jul 16, 2014, at 3:54 PM, Daniele Di Proietto <[email protected]> wrote: > > On Jul 16, 2014, at 3:30 PM, Pravin Shelar <[email protected]> wrote: > >> On Wed, Jul 16, 2014 at 2:47 PM, Daniele Di Proietto >> <[email protected]> wrote: >>> If vswitchd is compiled with DPDK support but started without --dpdk >>> argument, >>> it shouldn't print any dpdk initialization messages. >>> OVS_VSWITCHD_START (tests/ofproto-macros.at:54) is pretty strict about what >>> the >>> daemon prints when starting. >>> >>> The testcases failures were introduced with commit 95fb793ae73d >>> >> I think we can just remove that msg. > > Ok, I’ll send a v2. > > Thanks > >> >>> Signed-off-by: Daniele Di Proietto <[email protected]> >>> --- >>> lib/netdev-dpdk.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >>> index 6de1b2b..5ee105c 100644 >>> --- a/lib/netdev-dpdk.c >>> +++ b/lib/netdev-dpdk.c >>> @@ -1204,6 +1204,10 @@ dpdk_class_init(void) >>> static int >>> dpdk_ring_class_init(void) >>> { >>> + if (rte_eal_init_ret) { >>> + return 0; >>> + } >>> + >>> VLOG_INFO("Initialized dpdk client handlers:\n"); >>> return 0; >>> } >>> -- >>> 2.0.0 >>> >>> _______________________________________________ >>> dev mailing list >>> [email protected] >>> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=MV9BdLjtFIdhBDBaw5z%2BU6SSA2gAfY4L%2F1HCy3VjlKU%3D%0A&m=OzXAWAuxhQecThkMa7sEc1PASUlOC0PNPq0BL%2BEJGo4%3D%0A&s=727360369975b280ef8928dc222b1110098add5711d09d1e0c4095f73812664e > > _______________________________________________ > dev mailing list > [email protected] > https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=MV9BdLjtFIdhBDBaw5z%2BU6SSA2gAfY4L%2F1HCy3VjlKU%3D%0A&m=FkqS0%2BKJQHiWBY31Wpw%2BOWgzA5xtGkY2l4%2FgEQTo1pY%3D%0A&s=28bd79b31802c06e900252b41d83eebf695302a5060bfe0365138c28f57b01c5 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
