On Wed, Jul 30, 2014 at 12:32 PM, Saurabh Shah <[email protected]> wrote: > > >> -----Original Message----- >> From: Jesse Gross [mailto:[email protected]] >> Sent: Wednesday, July 30, 2014 12:28 PM >> To: Saurabh Shah >> Cc: [email protected] >> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation for kernel >> module. >> >> On Wed, Jul 30, 2014 at 4:58 AM, Saurabh Shah <[email protected]> >> wrote: >> > diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h >> > index 271a14e..9f94138 100644 >> > --- a/include/linux/openvswitch.h >> > +++ b/include/linux/openvswitch.h >> > @@ -40,8 +40,10 @@ >> > #ifndef _LINUX_OPENVSWITCH_H >> > #define _LINUX_OPENVSWITCH_H 1 >> > >> > +#ifndef OVS_WIN_DP >> > #include <linux/types.h> >> > #include <linux/if_ether.h> >> > +#endif >> >> This is a Linux kernel header file that we're trying to keep in sync, so it >> really >> shouldn't have any WIndows-specific things in it. > > The structures are used on windows too now. I could move this file to some > common header file location.
This file is actually from the Linux kernel, so I would really view it as a back port more than anything else. Ben had some patches to move things around a little while back and there was some discussion although nothing really came of it. For the specific case of include files, it's probably not that bad to separate those out and keep everything else the same. However, I don't know if that will be sufficient long term. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
