On Sep 11, 2014, at 11:42 AM, Ben Pfaff <[email protected]> wrote:
> On Wed, Sep 10, 2014 at 02:06:04PM -0700, Jarno Rajahalme wrote:
>> When probing for variable length userdata before handler threads are
>> set, the pid included in the userspace action will be 0, which is
>> flagged as an error by the linux kernel datapath. As a result the
>> feature probe will produce an unnecessary log message. By probing for
>> variable length userdata later the probe works as intended and the
>> unnecessary log message is avoided.
>>
>> Signed-off-by: Jarno Rajahalme <[email protected]>
>
> Would you mind adding a comment explaining why the check is placed as it
> is? It is not obvious.
>
Added this:
/* This check fails if performed before udpif threads have been set,
* as the kernel module checks that the 'pid' in userspace action
* is non-zero. */
Pushed to master,
Jarno
> Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
