On Sep 14, 2014, at 8:18 PM, Samuel Ghinet <sghi...@cloudbasesolutions.com> wrote:
> At first on reading this code, I was wondering "why?" > Now I think I understand: the function zeroes memory, and must return the ptr > to 'next' item to be filled (which is called "tail"). Am I correct? Yes, that is the bug. The pointer returned is the same pointer at where memory was zeroed. > Also, I think it would be nice if you could rename NlBufCopyAtTailUninit -> > NlBufZeroAtTailUninit or smth similar, because it does not actually do a > copy, and the name makes it a bit confusing. > But perhaps this would also work as a separate patch. Sure, I'll talk to Ankur about this since he designed and wrote this code. He might have some thoughts too. Thanks for the review. You can ack the v2 patch, which I'll send out. Thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
