On Mon, Sep 15, 2014 at 01:48:15PM -0700, Gurucharan Shetty wrote: > To prevent warnings such as "Not all control paths return a value", > we should define NO_RETURN for MSVC. > > Currently for gcc, we add NO_RETURN at the end of function declaration. > But for MSVC, "__declspec(noreturn)" is needed at the beginning of function > declaration. So this commit moves NO_RETURN to the beginning of the function > declaration as it works with gcc and clang too. > > Signed-off-by: Gurucharan Shetty <[email protected]>
Will you add a note above the definition of NO_RETURN that says it has to come first to make MSVC happy? Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
