Acked-by: Ethan Jackson <[email protected]>
On Sun, Sep 14, 2014 at 8:06 PM, Joe Stringer <[email protected]> wrote: > Although I reviewed and applied #1, I'll leave this one up to Ethan as it's > more relevant to his other proposed changes. > > On 13 September 2014 05:35, Daniele Di Proietto <[email protected]> > wrote: >> >> If 'configure' with clang fails (this can happen for example if it doesn't >> support all the cflags), simply skip it >> >> Signed-off-by: Daniele Di Proietto <[email protected]> >> --- >> utilities/ovs-dev.py | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py >> index 869d89e..934cddb 100755 >> --- a/utilities/ovs-dev.py >> +++ b/utilities/ovs-dev.py >> @@ -114,9 +114,12 @@ def conf(): >> except OSError: >> pass # Directory exists. >> >> - ENV["CC"] = "clang" >> - os.chdir(BUILD_CLANG) >> - _sh(*configure) >> + try: >> + ENV["CC"] = "clang" >> + os.chdir(BUILD_CLANG) >> + _sh(*configure) >> + except subprocess.CalledProcessError: >> + clang = False >> >> if sparse: >> c1 = "C=1" >> -- >> 2.1.0.rc1 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
