On Mon, Sep 15, 2014 at 02:25:13PM +1200, Joe Stringer wrote:
> Add the 128-bit murmurhash by Austin Appleby, for 32-bit systems from:
> http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp
>
> Signed-off-by: Joe Stringer <[email protected]>
Why does the loop in hash_words128 count up from a negative number to
zero?
Please put spaces after commas and around binary infix operators,
e.g. in these cases:
k1 = hash_rot(k1,15);
hash.h[0] = hash_rot(hash.h[0],19);
hash.h[0] = hash.h[0]*5+0x561ccd1b;
and similar.
It looks like there is a version of 128-bit murmurhash that uses 64-bit
operations. Did you consider it? Do you have any idea whether there is
a performance difference?
Did you look at the GCC-generated code to see that it was sane?
Did you do any testing of the hash function output? We have tests for
our main hash function.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
