Can you please change the name of the handler as it is handled multiple flow commands? Thanks, Eitan
-----Original Message----- From: dev [mailto:[email protected]] On Behalf Of Ankur Sharma Sent: Wednesday, September 24, 2014 12:16 AM To: [email protected] Subject: [ovs-dev] [PATCH v1 09/10] datapath-windows/Flow.c: FLOW_DEL command handler. Registered FLOW_DEL command handler. The same command handler as FLOW_ADD is good enough to handle FLOW_DEL case as well with minor changes for checking to action attribute. --- datapath-windows/ovsext/Datapath.c | 5 +++++ datapath-windows/ovsext/Flow.c | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index 5008aab..5377f09 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath-windows/ovsext/Datapath.c @@ -202,6 +202,11 @@ NETLINK_CMD nlFlowFamilyCmdOps[] = { .handler = OvsFlowNlNewCmdHandler, .supportedDevOp = OVS_TRANSACTION_DEV_OP, .validateDpIndex = FALSE + }, + { .cmd = OVS_FLOW_CMD_DEL, + .handler = OvsFlowNlNewCmdHandler, + .supportedDevOp = OVS_TRANSACTION_DEV_OP, + .validateDpIndex = FALSE } }; diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index e170de6..b95f69b 100644 --- a/datapath-windows/ovsext/Flow.c +++ b/datapath-windows/ovsext/Flow.c @@ -358,8 +358,11 @@ _OvsFlowMapNlToFlowPut(POVS_MESSAGE msgIn, PNL_ATTR keyAttr, mappedFlow); /* Map the action */ - mappedFlow->actionsLen = NlAttrGetSize(actionAttr); - mappedFlow->actions = NlAttrGet(actionAttr); + if (actionAttr) { + mappedFlow->actionsLen = NlAttrGetSize(actionAttr); + mappedFlow->actions = NlAttrGet(actionAttr); + } + mappedFlow->dpNo = ovsHdr->dp_ifindex; _OvsFlowMapNlToFlowPutFlags(genlMsgHdr, flowAttrClear, -- 1.9.1 _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=%2F3QxrtpSobNA3%2FWTY56L%2BM8bqjkdBR6i9%2BQs9KrCRoE%3D%0A&s=e4fe38f78f3b5da102fdb6aaa481ffb77bf978b32c2cfa1070c1f0835efdad6c _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
