On Wed, Sep 24, 2014 at 10:50:04AM +0900, YAMAMOTO Takashi wrote:
> > diff --git a/lib/nx-match.c b/lib/nx-match.c
> > index df39b4e..5970e44 100644
> > --- a/lib/nx-match.c
> > +++ b/lib/nx-match.c
> > @@ -1093,8 +1093,11 @@ parse_nxm_field_name(const char *name, int name_len)
> > /* Check whether it's a 32-bit field header value as hex.
> > * (This isn't ordinarily useful except for testing error behavior.) */
> > if (name_len == 8) {
> > - uint32_t header = hexits_value(name, name_len, NULL);
> > - if (header != UINT_MAX) {
> > + uint32_t header;
> > + bool ok;
> > +
> > + header = hexits_value(name, name_len, &ok);
> > + if (!ok) {
>
> inversed condition?
You are right.
Testing this with the condition fixed, I see that this revealed some
bug in some earlier patch. I will figure out what's going on and
repost the series.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
