On Fri, Oct 03, 2014 at 01:22:07PM -0700, Jarno Rajahalme wrote:
> Replace bitwise loops with a single operation, inline all bitmap
> functions. Inlining allows the compiler to remove unnecessary code
> due to some parameters being compile-time constants.
>
> Before:
>
> $ tests/ovstest test-bitmap benchmark 1000000
> bitmap equal: 341 ms
> bitmap scan: 8089 ms
>
> After:
>
> $ tests/ovstest test-bitmap benchmark 1000000
> bitmap equal: 152 ms
> bitmap scan: 146 ms
>
> Signed-off-by: Kmindg <[email protected]>
> Signed-off-by: Jarno Rajahalme <[email protected]>
I can't argue with the results.
I think you made significant changes to Kmindg's original patch.
You should probably either add a note saying how you changed it, e.g.
Signed-off-by: Kmindg <[email protected]>
[[email protected] updated this to frob the quux]
Signed-off-by: Jarno Rajahalme <[email protected]>
or just change it to a co-author relationship.
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev