On Oct 7, 2014, at 4:59 PM, Gurucharan Shetty <[email protected]> wrote:
> On Tue, Oct 7, 2014 at 4:35 PM, Nithin Raju <[email protected]> wrote: >> The init function must be dummy for the unit tests to pass. The >> unit tests don't require the kernel datpaath to be loaded, and >> without the kernel datapath, any calls netlink calls will fail. >> >> Signed-off-by: Nithin Raju <[email protected]> >> Reported-by: Gurucharan Shetty <[email protected]> > > Wouldn't it be better to simply not set .init for NETDEV_WINDOWS_CLASS > in this case? > Couple of trivial comments below. I was under the impression that .init is a mandatory function. Looks like it is not. Fixed, and other comments are not applicable now. thanks -- Nithin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
