> * --------------------------------------------------------------------------
> * Command Handler for 'OVS_WIN_NETDEV_CMD_GET'.
> @@ -1397,10 +1019,8 @@ OvsGetNetdevCmdHandler(POVS_USER_PARAMS_CONTEXT
> usrParamsCtx,
> NTSTATUS status = STATUS_SUCCESS;
> POVS_MESSAGE msgIn = (POVS_MESSAGE)usrParamsCtx->inputBuffer;
> POVS_MESSAGE msgOut = (POVS_MESSAGE)usrParamsCtx->outputBuffer;
> - NL_ERROR nlError = NL_ERROR_SUCCESS;
> OVS_VPORT_GET vportGet;
> OVS_VPORT_EXT_INFO info;
> - LOCK_STATE_EX lockState;
>
> static const NL_POLICY ovsNetdevPolicy[] = {
> [OVS_WIN_NETDEV_ATTR_NAME] = { .type = NL_A_STRING,
> @@ -1434,16 +1054,6 @@ OvsGetNetdevCmdHandler(POVS_USER_PARAMS_CONTEXT
> usrParamsCtx,
> RtlCopyMemory(&vportGet.name, NlAttrGet(netdevAttrs[OVS_VPORT_ATTR_NAME]),
> NlAttrGetSize(netdevAttrs[OVS_VPORT_ATTR_NAME]));
>
> - NdisAcquireRWLockRead(gOvsSwitchContext->dispatchLock, &lockState, 0);
> - status = OvsGetExtInfoIoctl(&vportGet, &info);
> - if (status == STATUS_DEVICE_DOES_NOT_EXIST) {
> - nlError = NL_ERROR_NODEV;
> - NdisReleaseRWLock(gOvsSwitchContext->dispatchLock, &lockState);
> - OvsReleaseCtrlLock();
> - goto cleanup;
> - }
> - NdisReleaseRWLock(gOvsSwitchContext->dispatchLock, &lockState);
> -
hi Alin,
Thanks for sending the respin.
I looked at this particular patch, and noticed that the definition of
OvsGetExtInfoIoctl() has been nuked. The netdev changes I introduced reply on
this function. I was thinking that we'll have compilation issues, but looks
like you've removed the call to OvsGetExtInfoIoctl() itself. This is not right.
Are you adding the call back in another patch?
-- Nithin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
