This was one of the review comment which i forgot to address in FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero as caller would have already set it.
Signed-off-by: Ankur Sharma <ankursha...@vmware.com> --- datapath-windows/ovsext/Flow.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 1431761..b87e4e2 100644 --- a/datapath-windows/ovsext/Flow.c +++ b/datapath-windows/ovsext/Flow.c @@ -269,8 +269,6 @@ OvsFlowNlCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx, RtlZeroMemory(&stats, sizeof(stats)); RtlZeroMemory(&replyStats, sizeof(replyStats)); - *replyLen = 0; - /* Get all the top level Flow attributes */ if ((NlAttrParse(nlMsgHdr, attrOffset, NlMsgAttrsLen(nlMsgHdr), nlFlowPolicy, nlAttrs, ARRAY_SIZE(nlAttrs))) @@ -381,8 +379,6 @@ OvsFlowNlGetCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx, NL_ERROR nlError = NL_ERROR_SUCCESS; POVS_MESSAGE msgIn = (POVS_MESSAGE)usrParamsCtx->inputBuffer; - *replyLen = 0; - if (usrParamsCtx->devOp == OVS_TRANSACTION_DEV_OP) { rc = _FlowNlGetCmdHandler(usrParamsCtx, replyLen); } else { @@ -435,8 +431,6 @@ _FlowNlGetCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx, UINT32 keyAttrOffset = 0; UINT32 tunnelKeyAttrOffset = 0; - *replyLen = 0; - if (usrParamsCtx->inputLength > usrParamsCtx->outputLength) { /* Should not be the case. * We'll be copying the flow keys back from -- 1.9.1 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev