On Sat, Oct 11, 2014 at 08:56:07PM -0400, Thomas F Herbert wrote:
> This is the userspace portion of the patch.
>
> Signed-off-by: Thomas F Herbert <thomasfherb...@entpnt.com>
Thanks for the patch. I have some comments.
I don't understand the struct flow members yet. Previously, there was
a vlan_tci member, which indicated the presence and TCI of an 802.1Q
header. Now there are two of these; I understand that part. I don't
understand the new vlan_tpid member, because I would expect there to
be two of these also, one for each tci.
Some of the new code has missing {} around some statements, e.g. in
flow_get_vlan_depth() and pop_vlan(). (See CodingStyle.)
I need to continuing reviewing this once I understand the struct flow
design.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
