On Thu, Oct 23, 2014 at 11:27 AM, Justin Pettit <[email protected]> wrote:
> This isn't a full review, but I just wanted to point out again about the
> documentation string and I noticed a small typo in a comment.
>
>> + /* Get datapath version. Caller is responsible for free the string
>> + * returned. */
>
> s/free/freeing/
>
>> + <column name="datapath_version">
>> + Reports the OpenFlow datapath version in use. Can be empty if
>> + datapath version can not be determined.
>
> This still refers to OpenFlow instead of Open vSwitch.
Had a question in my previous email: 'OpenFlow datapath' was used in
datapath_id description.
If Open vSwitch is a better name, we should consider change both. I
was not ignoring the comment,
just waiting for an answer.
<column name="datapath_id">
Reports the OpenFlow datapath ID in use. Exactly 16 hex digits.
(Setting this column has no useful effect. Set <ref
column="other-config" key="datapath-id"/> instead.)
</column>
>
> --Justin
>
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
