On Thu, Oct 23, 2014 at 11:38:48AM -0700, Jarno Rajahalme wrote: > > On Oct 23, 2014, at 8:22 AM, Ben Pfaff <[email protected]> wrote: > > > >> On Thu, Oct 23, 2014 at 12:04:18PM +0200, Thomas Graf wrote: > >> Exposes the necessary structs and functions in classifier.h to allow > >> test-classifier.c to use the header and link to the library instead > >> of including classifier.c directly. > >> > >> Adds VLOG_DECLARE_THIS_MODULE() which allows to extend the namespace > >> of a vlog module. > >> > >> Also adds an assert to VLOG_DEFINE_MODULE() to catch duplicate > >> definitions with a proper backtrace. > >> > >> Cc: Scott Mann <[email protected]> > >> Cc: Ben Pfaff <[email protected]> > >> Cc: Gurucharan Shetty <[email protected]> > >> Signed-off-by: Thomas Graf <[email protected]> > > > > Jarno, are you OK with this? It solves a problem building with > > --enable-shared (which I'd add to the commit message): > > http://archives.openvswitch.org/pipermail/dev/2014-October/047674.html > > I'd rather not expose the classifier internals in a shared library > ABI, even if it is versioned. I'll see if there is another > solution. What was the problem?
Two different definitions of a "classifier" vlog module, in different source files (lib/classifier.c directly and tests/test-classifier.c #include'ing classifier.c). _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
