On Thu, Oct 23, 2014 at 07:48:06PM +0000, Alin Serdean wrote:
> Hi Nithin,
>
> Don't know what to say about but probably Ben or others maybe would like the
> following approach:
>
> +#ifdef _WIN32
> +enum { WINDOWS = 1 };
> +#else
> +enum { WINDOWS = 0 };
> +#endif
> The "ovs_assert(!WINDOWS*" can be ifdef out in my opinion.
The use of an enum was my suggestion. I prefer code that gets
compiled and therefore checked by the compiler everywhere, rather than
only on one platform, and this approach helps with that.
> Also personally I do not like the wrapper approach for
> vport_create_socksp, vport_del_socksp, dpif_netlink_handler_uninit
> and dpif_netlink_handler_init .
Maybe this can be improved. I'm going to withhold judgment until the
Windows support is closer to its final form.
> error = dpif_netlink_recv_windows(dpif, handler_id, upcall, buf);;
> Lose the second ;
> /* Multiple upcall handlers will be supported once kernel datpaath supports
> *datapath
Thanks, I folded this in.
> Acked-by: Alin Gabriel Serdean <[email protected]>
Thanks for the ack.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
