Thanks for pointing that out. That's a mistake. I meant for each of them to test a different OFPERR_OFPBAC_BAD_LEN case in ofpact_pull_raw().
I fixed that and applied this to master. On Thu, Oct 23, 2014 at 02:10:42PM -0700, Andy Zhou wrote: > What is the significance of the 3 different test cases? It appears > they all hit the same error condition. > > On Thu, Oct 23, 2014 at 1:40 PM, Ben Pfaff <[email protected]> wrote: > > On Mon, Oct 20, 2014 at 02:45:42PM -0700, Ben Pfaff wrote: > >> Commit c2d936a44fa (ofp-actions: Centralize all OpenFlow action code for > >> maintainability.) rewrote OpenFlow action parsing but failed to check that > >> actions don't overflow their buffers. This commit fixes the problem and > >> adds negative tests so that this bug doesn't recur. > >> > >> Reported-by: Tomer Pearl <[email protected]> > >> Signed-off-by: Ben Pfaff <[email protected]> > > > > This fixes a crash bug so I'd appreciate a review. > > _______________________________________________ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
