Hi Ankur, After Nithin's head up on this, I have verified and the issue I raised is incorrect. Indeed, the head of a LIST_ENTRY does not contain a valid element. I was expecting to have a NULL pointer, instead of a dummy one.
Thanks, Sorin -----Original Message----- From: Ankur Sharma [mailto:ankursha...@vmware.com] Sent: Thursday, October 23, 2014 8:53 PM To: Nithin Raju; Sorin Vinturis Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2 2/6] datapath-windows: pid-instance hash table APIs. Hi Sorin, Kindly let me know if you have concerns over it. As per my understanding as well we are not skipping any valid list node. Thanks. Regards, Ankur ________________________________________ From: Nithin Raju Sent: Wednesday, October 22, 2014 4:55 PM To: Sorin Vinturis Cc: Ankur Sharma; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/6] datapath-windows: pid-instance hash table APIs. On Oct 22, 2014, at 6:30 AM, Sorin Vinturis <svintu...@cloudbasesolutions.com> wrote: > [Sorin] > The lines above searches through the pidHashArray for the requested pid, but > fails to check the first element of the array. Did you mean to say, that we don't check the first element in the linked list? The first element is 'head' and it is a dummy. 'head' itself, does not have a CONTAINING_RECORD() AFAIK. Please see the code in: km/wdm.h in the Visual Studio kernel includes. Thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
